开发者

Why to copy a dictonairy from WSGI environment?

In the following example from wsgi.org is cur开发者_StackOverflow中文版_named copied:

def __call__(self, environ, start_response):
    script_name = environ.get('SCRIPT_NAME', '')
    path_info = environ.get('PATH_INFO', '')
    for regex, application in self.patterns:
        match = regex.match(path_info)
        if not match:
            continue
        extra_path_info = path_info[match.end():]
        if extra_path_info and not extra_path_info.startswith('/'):
            # Not a very good match
            continue
        pos_args = match.groups()
        named_args = match.groupdict()
        cur_pos, cur_named = environ.get('wsgiorg.routing_args', ((), {}))
        new_pos = list(cur_pos) + list(pos_args)
        new_named = cur_named.copy() # Why copy()?
        new_named.update(named_args)
        environ['wsgiorg.routing_args'] = (new_pos, new_named)
        environ['SCRIPT_NAME'] = script_name + path_info[:match.end()]
        environ['PATH_INFO'] = extra_path_info
        return application(environ, start_response)
    return self.not_found(environ, start_response)

Why not to call ur_named.update(named_args) directly?


Do you know where cur_named dict came from? Just imaging something like the following:

SOME_CONFIG = {
    'some_key': ((..., ...), {...}),
    ...
}

environ['wsgiorg.routing_args'] = SOME_CONFIG['some_key']

Now when you update new_named in-place you are actually updating inner dictionary inside SOME_CONFIG which will bring your data to other requests. The safe way is to copy dictionary unless you are sure it's not needed.

0

上一篇:

下一篇:

精彩评论

暂无评论...
验证码 换一张
取 消

最新问答

问答排行榜