开发者

Why do I get an error message that .replace is not a function? [duplicate]

This question already has answers here: var.replace is not a function (10 answers)开发者_如何学编程 Closed 8 years ago.

I have this function:

function countLitreKgSums(cProductIds){
  var cLitreKgSums = new Array();
  var cWeek = 0;
  for(i=0;i<cProductIds.length;i++){
    var cLitreKgSum = 0;
    $("#plan_table td[class='week']").each(function(){
            cWeek = $(this).html();
            var cLitreKgValue = $("input[name*='plan_table_week" + cWeek + "_prod" + cProductIds[i] + "_']").val();
            if (cLitreKgValue == "") {
                cLitreKgValue = 0;
            }
            cLitreKgValue = cLitreKgValue.replace(/,/g, '.').replace(/[^\d\.]/g, '').replace(/\s/g, '');
            cLitreKgValue = parseFloat(cLitreKgValue);
            cLitreKgSum += cLitreKgValue;
       });
       cLitreKgSum = Math.round(cLitreKgSum * 100) / 100;
       cLitreKgSums[i] = cLitreKgSum;
  }
  return cLitreKgSums;
  //console.log(cLitreKgSums);
}

I get error message that .replace is not a function but in other functions it works as it should. What is the difference?


cLitreKgValue might be a number at the point where you try to call replace on it, not a string. In which case, the error is correct - numbers don't have a replace method.


Change this:

cLitreKgValue.replace(/,/g, '.')

to

("" + cLitreKgValue).replace(/,/g, '.')


you can use the function String()
i.e.; String(cLitreKgValue).replace ....
String function:
http://www.w3schools.com/jsref/jsref_string.asp


While the other answers work (and are correct, numbers don't have .replace(), it's a String method), I think an overall structure change is better, like this:

$("#plan_table td[class='week']").each(function(){
    cWeek = $(this).html();
    var cLitreKgValue = $("input[name*='plan_table_week" + cWeek + "_prod" + cProductIds[i] + "_']").val();
    if (cLitreKgValue !== "") {
      cLitreKgValue = cLitreKgValue.replace(/,/g, '.').replace(/[^\d\.]/g, '').replace(/\s/g, '');
      cLitreKgSum += parseFloat(cLitreKgValue);
    }
});

There's no reason to do all that work when you know it's 0 and doesn't affect the result, so if "" means 0 and anything += 0 has no net effect, just skip it :)

0

上一篇:

下一篇:

精彩评论

暂无评论...
验证码 换一张
取 消

最新问答

问答排行榜