Elegant PHP variables
An empty $movies array given to the for loop will yield a warning. Checking for null avoids this. Not that i see this as ugly or messy code i'd just like to know if there are any more elegant ways of handling these instances.
function get_db_movies($db_handle) {
$query = "SELECT title FROM movies";
$result = $db_handle->query($query);
$movies = null;
while($row = mysql_fetch_array($result)){
$movie =开发者_高级运维 new Movie($row['title'], $db_handle);
$movies[] = $movie;
}
return $movies;
}
$movies = get_db_movies($db_handle);
foreach($movies as $movie) {
$imdbCrawl = new imdbCrawler($movie);
if($imdbCrawl->verifyMatch() && $imdbCrawl->isMovieFound()) {
$imdbCrawl->getRating();
$imdbCrawl->getPlot();
$movie->syncDatabase();
} else {
echo "Movie crawl failed: " . $movie->getTitle();
}
}
Initialize $movies to an empty array instead of null:
$movies = array();
You may initialize an array before use to avoid the warning:
$movies = array();
精彩评论