Sort Function in 'usort' being "evaled" in PHP? Fatal error: cannot redeclare function?
Recently stumbled upon this neat little bug or 'feature' in PHP:
function myCmpFunc($a,$b) {
function inner($p) {
// do something
}
$inner_a = inner($a);
$inner_b = inner($b);
if ($inner_a == $inner_b) return 0;
return ($inner_a > $inner_b ? -1 : 1);
}
Results in a fatal error "cannot redeclare function inner in ...", when called like this
usort($myArray, 'myCmpFunc');
It works flawlessly when function inner is declared outside of myCmpFunc and/or $myArray has not more than 2 elements ;)
-- edit --
somehow Related: PHP Fatal error: Cannot redeclare function
So here is my question, then: Is it possible to declare functions in local scope?
-- edit 2 --
Maybe, this works 开发者_Go百科well in PHP 5.3 just read it has closures, yeehaa!
function inner($p)
is defined each time that function myCmpFunc($a,$b)
is executed. Furthermore, the inner function is visible outside function myCmpFunc($a,$b)
after that (which pretty much takes the sense out of allowing nested function definitions). That's why you get a duplicate definition error when you call the outer function a second time.
To work around this, check whether function_exists
in the body of function myCmpFunc($a,$b)
.
As of PHP v5.3 one can now write it the nice way:
$myCmpFunc = function ($a, $b) {
static $inner = function ($element) {
return $element['width']; // just as an example
};
$inner_a = $inner($a);
$inner_b = $inner($b);
if ($inner_a == $inner_b) return 0;
return ($inner_a > $inner_b ? -1 : 1);
};
usort($anArray, $myCmpFunc);
The function declaration is inside myCmpFunc
, and because usort
would call myCmpFunc
for each element of an array, what happens is similar to declaring a function N times.
The issue is you must call the outer function before using the inner function. As per this answer to a similar question Can I include a function inside of another function?
So your use of inner($a);
is not valid.
精彩评论