C, Printing more than one integer from a linked list

I'm very new to C, so I'm not totally sure what's the matter. I can't figure out how to print more than a single integer value in a function.

add function:

void add(char *name,int id,int copies)
{
/* Pointer to next item */
struct list *newAlbum;

newAlbum = malloc(sizeof(struct list)); 
strcpy((*newAlbum).name, name);  // Set album name
newAlbum->id = id;
newAlbum->copies = copies;
newAlbum->pNext = pFirst; 
pFirst = newAlbum;
}

show function:

void show()
{   
system("clear");
struct list *current_node;
current_node = pFirst;
while(current_node != NULL)
{   
    printf("Album #%d \n",current_node->id);
    printf("Album Name: %s \n",current_node->name);
    printf("Album Copies:%d \n",current_node->copies);
    printf("\n");
    current_node=current_node->pNext;
}
}

My program prints out the current_node->id as if it were current_node->copies, and current_node->copies is printed out as 134516043, which is obviously, wrong.

I think I must be passing something wrong to the function or so开发者_C百科mething, but I can't figure it out. Any tips?

I call the function add like this:

add(name,id,copies);

The list is as so:

 /* THE LIST */
 struct list{
    char name[52];
    int id;
    int copies;
    int sold;
    struct list* pNext;
};
struct list *pFirst = NULL;

I call the function with user input with this piece of code:

printf("Enter the name of the new album. \n");
scanf("%s",&name);
printf("Enter the album id. \n");
scanf("%d",&id);
printf("Enter number of copies. \n");
scanf("%d," &copies);
// Pass data to add()
add(name,id,copies);

Your code that you've shown is OK, as long as you don't pass an album name to add() which is longer than 51 characters. If you do, you'll get very weird output, and possibly a crash.

To guard against this, you should use a length-limited copy - for example:

void add(char *name,int id,int copies)
{
    /* Pointer to next item */
    struct list *newAlbum;

    newAlbum = malloc(sizeof *newAlbum);
    if (newAlbum) {
        snprintf(newAlbum->name, sizeof newAlbum->name, "%s", name);  // Set album name
        newAlbum->id = id;
        newAlbum->copies = copies;
        newAlbum->pNext = pFirst;
        pFirst = newAlbum;
    }
}

(note that sizeof *newAlbum is a little better than sizeof(struct list), since the former is "obviously correct" when reading the line - it will still be corret if the type of newAlbum is ever changed).

The only thing I can see wrong here is that you don't check the length of name. You should use:

strncpy(newAlbum->name, 52, name);

This will prevent overrunning the name buffer.