开发者

Erlang missing messages

I'm running the following code with dbg:p(client, r):

-module(client).
-export([start/0, start/2, send/1, net_client/1]).

start() ->
    start("localhost", 7000).

start(Host, Port) ->
    io:format("Client connecting to ~p:~p.~n", [Host, Port]),
    register(ui, spawn(fun() -> gui_control([]) end)),
    case gen_tcp:connect(Host, Port, [binary, {packet, 0}]) of
        {ok, Socket} ->
            Pid = spawn(client, net_client, [Socket]),
            register(client, Pid),
            gen_tcp:controlling_process(Socket, Pid);
        Error ->
            io:format("Error connecting to server: ~p~n", [Error]),
            erlang:error("Could not connect to server.")
    end,
    ok.

send(Msg) ->
    client!{send, Msg}.


%% Forwards messages to either the GUI controller or the server.
net_client(Socket) ->
    receive
        {tcp, Socket, Message} ->
            Msg = binary_to_term(Message),
            io:format("Received TCP message on ~p: ~p~n", [Socket, Msg]),
            ui!{server, Msg};
        {send, Message} ->
            io:format("Sending ~p.~n", [Message]),
            gen_tcp:send(Socket, term_to_binary(Message));
        close ->
            gen_tcp:close(Socket),
            exit(normal);
        {tcp_closed, Socket} ->
            io:format("Server terminated connection.~n"),
            exit(normal); %% Reconnect?
        timeout -> %% This
            io:format("Timed out?~n");
        {inet_reply, Socket, Message} -> %% and this never happen.
            io:format("inet_reply: ~p~n", Message);
        Error ->
            io:format("Net client got bad message: ~p.~n", [Error])
    after 10000 ->
            refresh %% gen_tcp:send(Socket, term_to_binary(keepalive))
    end,
    ?MODULE:net_client(Socket).


gui_control(Data) ->
    receive
        %% This will hang the gui until the sync is done. Not sure if
        %% that's okay.
        {server, {sync, Datum}} -> % Resync command from server.
            gui_control(resync([Datum]));
        {client, refresh} -> % Refresh request from display.
            display:update(Data);
        {server, Msg} ->
            io:format("UI Rx: ~p~n", [Msg])
    end,
    gui_control(Data).

resync(Data) ->
    receive
        {server, {sync, Datum}} ->
            resync([Datum|Data]);
        {server, {done, Num}} ->
            case length(Data) of
                Num ->
                    Data;
                _ ->
                    io:format("Got done before all the data were received.~n"),
                    send({sync})
            end
    after 5000 ->
            io:format("Timed out waiting for data.~n"),
            send({sync})
    end.

It communicates with a server I wrote with gen_tcp and gen_server, following this. My 开发者_StackOverflowmain problem is that I don't reliably receive all my messages. Sometimes I'll get

(<0.2.0>) << {tcp,#Port<0.517>,
                  <<131,104,6,100,0,4,99,97,114,100,100,0,7,117,110,107,110,
                    111,119,110,100,0,7,117,110,107,110,111,119,110,106,106,
                    104,3,107,0,6,83,101,99,111,110,100,100,0,4,100,114,97,
                    119,97,2,131,104,6,100,0,4,99,97,114,100,100,0,7,117,110,
                    107,110,111,119,110,100,0,7,117,110,107,110,111,119,110,
                    106,106,104,3,107,0,6,83,101,99,111,110,100,100,0,4,100,
                    114,97,119,97,3,131,104,6,100,0,4,99,97,114,100,100,0,7,
                    117,110,107,110,111,119,110,100,0,7,117,110,107,110,111,
                    119,110,106,106,104,3,107,0,5,70,105,114,115,116,100,0,4,
                    100,114,97,119,97,0>>}

from the debugging output, but no corresponding Received TCP message on #Port<0.517>:... message. I'll also see things like this:

(<0.2.0>) << {io_reply,<0.24.0>,ok}
(<0.2.0>) << timeout
(<0.2.0>) << {io_reply,<0.24.0>,ok}
(<0.2.0>) << timeout
(<0.2.0>) << {io_reply,<0.24.0>,ok}

but nothing from net_client's receive. I've watched the network traffic with wireshark and I know the packets are getting where they're supposed to go and being ACKed. What am I doing wrong?

Edit: I'm invoking this with erl -smp enable -eval "client:start()." in case it matters.


I guess the basic problem is that 'net_client' should be spawned off as a separate process..

In the start method, change

register(client, self()),
net_client(Socket);

to

register(client, fun() -> net_client(Socket) end);

that should solve it..


Also, I recommend using redbug (part of eper) https://github.com/massemanet/eper when tracing. It protects you from drowning your system in trace output and provides a dead simple syntax, eg: redbug:start("mymod:foo -> return", [{msgs,10}]). trace all calls to mymod:foo and what those calls return but give me no more than 10 trace messages.


Turns out {packet, 0} was my problem. Replace that with {packet, 2} and all is well.

0

上一篇:

下一篇:

精彩评论

暂无评论...
验证码 换一张
取 消

最新问答

问答排行榜