f.error_messages in Rails 3.0

Rails 3.0 deprecated f.error_messages and now requires a plugin to work correctly - I however want to learn how to display error messages the (new) native way. I am following the getting started guide, which uses the deprecated method when implementing the comments form. For example:

<h2>Add a comment:</h2>
<%= form_for([@post, @post.comments.build]) do |f| %>
  <%= f.error_messages %>
<div class="field">
  <% f.label :commenter  %><br />
  <%= f.text开发者_如何转开发_field :commenter  %>
</div>
<div class="field">
  <%= f.label :body %><br />
  <%= f.text_area :body %>
</div>
<div class="actions">
  <%= f.submit %>
</div>
<% end %>

Here is the correct way to do it (as generated by the scaffold):

<%= form_for(@post) do |f| %>
  <% if @post.errors.any? %>
    <div id="error_explanation">
      <h2><%= pluralize(@post.errors.count, "error") %> prohibited this post from being saved:</h2>

      <ul>
      <% @post.errors.full_messages.each do |msg| %>
        <li><%= msg %></li>
      <% end %>
      </ul>
    </div>
  <% end %>
 . . . 

I understand that I use the @post variable in the latter example, but what variable do I reference in the former to get the error messages for comment creation?

The best and clean way to implement error_messages in your form is by implementing error_messages in a FormBuilder.

For example, here is the error_messages method I've implemented for my last project. By implemeting your own FormBuilder you can follow the rules and styles of your webdesigner... Here is an example that will output the errors list in ul/li's with some custom styles :

class StandardBuilder < ActionView::Helpers::FormBuilder
  def error_messages
    return unless object.respond_to?(:errors) && object.errors.any?

    errors_list = ""
    errors_list << @template.content_tag(:span, "There are errors!", :class => "title-error")
    errors_list << object.errors.full_messages.map { |message| @template.content_tag(:li, message) }.join("\n")

    @template.content_tag(:ul, errors_list.html_safe, :class => "error-recap round-border")
  end
end

Then in my forms :

= f.error_messages

And that's all.

I'm pretty sure all you'd need to do is reference @post.comments

So you could do something like:

<% @post.comments.each do |comment| %>
    <% if comment.errors.any? %>

    <% comment.errors.full_messages.each do |msg| %>
        <li><%= msg %></li>
    <% end %>

    <% end %>
<% end %>

Or just pull all the errors out out:

comment_errors = @post.comments.map(&:errors)

and then loop through them in your display logic to output each of the comment errors.

This functionality exists as a standalone gem dynamic_form.

Add the the following to your Gemfile

gem 'dynamic_form'

From the github page:

DynamicForm holds a few helpers method to help you deal with your Rails3 models, they are:

• input(record, method, options = {})
• form(record, options = {})
• error_message_on(object, method, options={})
• error_messages_for(record, options={})

It also adds f.error_messages and f.error_message_on to your form builders.

Here is my solution to the whole error scene.

I created a partial which simply uses a model variable which one would pass when rendering it:

<%# app/views/errors/_error.html.erb %>

<%= content_for :message do %>
  <% if model.errors.any? %>
    <ul>
      <% model.errors.full_messages.each do |msg| %>
        <li><%= msg %></li>
      <% end %>
    </ul>
  <% end %>
<% end %>

You can easily add dynamic html class and/or id names based on the name of the model, as well as generic ones.

I have things setup where my error messages render in all the same place in a layout file:

<%# app/views/layouts/application.html.erb %>

<%= yield :message %>

If one didn't want that functionality, removing the content_for in the partial would do the trick.
Then in really any view you want you can simply write:

<%= render 'errors/error', model: @some_model %>

One could further expand this by creating a partial which takes a collection and leverages the error partial above:

<%# app/views/errors/_collection.html.erb %>

<% collection.each do |model| %>
  <%= render 'errors/error', model: model %>
<% end %>

Render it with:

<%= render 'errors/collection', collection: @some_model.some_has_many_association %>

I like this way. It is simple, easy to manage/maintain, and incredibly tweakable.
I hope this helps!

EDIT: Everything in HAML

-# app/views/errors/_error.html.haml

= content_for :message do
  - if model.errors.any?
    %ul
      - model.errors.full_messages.each do |msg|
        %li= msg

-# app/views/layouts/application.html.haml

= yield :message

= render 'errors/error', model: @some_model

-# app/views/errors/_collection.html.haml

- collection.each do |model|
  = render 'errors/errors', model: @some_model

= render 'errors/_collection', collection: @some_model.some_has_many_association

I guess that the [@post, @post.comments.build] array is just passed to polymorphic_path inside form_for. This generates a sub-resource path for comments (like /posts/1/comments in this case). So it looks like your first example uses comments as sub-resources to posts, right?.

So actually the controller that will be called here is the CommentsController. The reason why Lukas' solution doesn't work for you might be that you actually don't use @post.comments.build inside the controller when creating the comment (it doesn't matter that you use it in the view when calling form_for). The CommentsController#create method should look like this (more or less):

def create
  @post = Post.find(params[:post_id]
  @comment = @post.comments.build(params[:comment])

  if(@comment.save)
    # you would probably redirect to @post
  else
    # you would probably render post#show or wherever you have the form
  end
end

Then you can use the code generated by scaffolding, only replace @post instance variable with @comment in all the lines except form_for call.

I think it may also be a good idea to add the @comment = @post.comment.build to the controller method that displays this form and use form_for([@post, @comment], ...) to keep the form contents displayed in the form if there're errors.

If this doesn't work and you're not able to figure it out, please add your CommentsController#create method to the question.

I just looked into the docrails github issues, and they've decided to remove f.error_messages instead of explaining how to do validation for comments.

a rather simple implementation can be achieved with

class ActionView::Helpers::FormBuilder
  def error_message(method)
    return unless object.respond_to?(:errors) && object.errors.any?

    @template.content_tag(:div, object.errors.full_messages_for(:"#{method}").first, class: 'error')
  end
end

which allows one to use

 <%= form.label :first_name %>
 <%= form.text_field :first_name %>
 <%= form.error_message :first_name %>

and with the following sass

@import variables

.error
  padding: $margin-s
  margin-left: $size-xl
  color: red

.field_with_errors
  input
    border: 1px red solid

  input:focus
    outline-color: red

it looks like

using simple form gives you quite similiar functionality with more advanced functionality.

For example check out their examples with bootstrap