开发者

How to consolidate my repetitive jQuery code into a single function?

jQuery beginner here.

Here is what I'm working on. I have an area map with 10 hotspots on it. Hover over each of the hotspots and it shifts the background of the div (id=dialpad) to disp开发者_StackOverflowlay other data (in a sprite).

The code I have currently works, but I have a separate function for each hotspot ID.

Ex:

    $('#dial1')
    // On mouse over, move the background on hover
   .mouseover(function() {
     $('#dialpad').css('backgroundPosition', '0 -120px');
   })
   // On mouse out, move the background back
   .mouseout(function() {
     $('#dialpad').css('backgroundPosition', '0 0');
   })
     $('#dial2')
    // On mouse over, move the background on hover
   .mouseover(function() {
     $('#dialpad').css('backgroundPosition', '0 -240px');
   })
   // On mouse out, move the background back
   .mouseout(function() {
     $('#dialpad').css('backgroundPosition', '0 0');
   });
   ...

What I want to do is to consolidate that code into a single function where I simply pass the vertical offset figure from each area ID.

Can someone assist?


$('#dial1,#dial2').hover(
    function() { changePosition('0 ' + (parseInt(this.id.match(/\d+$/)[0])) * -120 + 'px'); },
    function() { changePosition('0 0'); }
);

function changePosition(position) {
   $('#dialpad').css('backgroundPosition', position);
}

Update:

Alternatively, if the "hotspots" occur on the page in the same order as the index numbers, then you could take a slightly more efficient approach and give them all a class and use the index property of .each() to determine the proper index number.

$('.hotspots').each(function( idx ) {
    $(this).hover(
        function() { changePosition('0 ' + ((idx + 1) * -120) + 'px'); },
        function() { changePosition('0 0'); }
    );
});

function changePosition(position) {
   $('#dialpad').css('backgroundPosition', position);
}

In fact, you really don't need the changePosition() function if you don't want it. The code is short enough that a little repetition is not a big deal.

$('.hotspots').each(function( idx ) {
    $(this).hover(
        function() { $('#dialpad').css('backgroundPosition', '0 ' + ((idx + 1) * -120) + 'px')},
        function() { $('#dialpad').css('backgroundPosition', '0 0'); }
     );
});​


Here's a variation using closures/function-generator for the callbacks:

function setOffset(offset) {
    return (function() { $('#dialpad').css('backgroundPosition', offset); });
}       
$('#dial1,#dial2').each(function(i) {
    $(this).hover(setOffset('0 -' + (120 * (i+1)) + 'px'), setOffset('0 0'));
});


Cleanest way is to make a quick plugin:

(function($){
  $.fn.mysprite = function(options){
    //merge the provided options with defaults
    var o = $.extend($.fn.mysprite.defaults, options||{});

    // this is the main body, here we iterate over the set 
    // returned by the selector applying the new functionality 

    this.each(function(){
      switch(typeof o.target){
         case 'object':
         case 'string':
           var target = $(o.target);
           break;
         case null:
           var target = $(this);
           break;
         default:
           // no target specified!
           return this;   
      }

      //simplify your previous code with the hover method

      $(this).hover(
        function(){
          target.css('backgroundPosition', o.offsetIn);
        }, 
        function(){
          target.css('backgroundPosition', o.offsetOut);
        });
    });

    return this;
  };

  // setsup class defaults
  $.fn.mysprite.defaults = {
    offsetIn: '0 0',
    offsetOut: '0 0',
    target: null
  };
})(jQuery);

//invoke with

$('#dialpad1').mysprite({offsetIn: '0 100', offsetOut: '0 0', target: '#dialpad'});


function setupDial(selector, offset) {
  function resetPos() {
     $('#dialpad').css('backgroundPosition', '0 0');
  }
  function setPos(int p) {
    return function() {
       $('#dialpad').css('backgroundPosition', '0 ' + p + 'px');
    }
  }

  $(selector)
    // On mouse over, move the background on hover
    .mouseover(setPos(offset))
   // On mouse out, move the background back
   .mouseout(resetPos);
}

setupDial('#dial1', -120);
setupDial('#dial2', -240);
0

上一篇:

下一篇:

精彩评论

暂无评论...
验证码 换一张
取 消

最新问答

问答排行榜