gcc warning in pointer to function (incompatible pointer type)
I need help with gcc warning,looks like im doing something wrong here
unsigned long convert_syslog(char *date,int year) {开发者_开发百科
char withyear[1024];
struct tm tm;
time_t epoch = (time_t) NULL;
snprintf(withyear,sizeof(withyear),"%s %i",date,year);
if(strptime(withyear,"%b %d %H:%M:%S %Y",&tm)) {
epoch = mktime(&tm);
printf("%u\n",epoch);
}
return epoch;
}
unsigned long convert_tai64(char *date,int year) {
char hex[16];
unsigned long u;
strcpy(hex,"0x");
strcat(hex,strndup(date+8,8));
return strtoul (hex,NULL,16);
}
unsigned long convert_nagios(char *date,int year) {
return strtoul(date,NULL,10);
}
unsigned long convert_clf(char *date,int year) {
struct tm tm;
time_t epoch = (time_t)NULL;
if(strptime(date,"%d/%b/%Y:%H:%M:%S",&tm)) {
epoch = mktime(&tm);
}
return epoch;
}
typedef unsigned long (*func)(char *data,int year);
func *convert_date(int pos) {
switch(pos) {
case 0: return &convert_syslog;
case 1: return &convert_tai64;
case 2: return &convert_clf;
case 3: return &convert_nagios;
default: return NULL;
}
}
gives me warnings in convert_date
pcre_search.c:57: warning: return from incompatible pointer type (case 0)
pcre_search.c:58: warning: return from incompatible pointer type (...)
pcre_search.c:59: warning: return from incompatible pointer type (...)
pcre_search.c:60: warning: return from incompatible pointer type (default)
You should return func
not func*
.
The func typedef is already a pointer to a function so convert_date can be declared like this:
func convert_date(int pos) { ...
Function names (in C) are already pointers so no need for the & in the return statements. Just do this:
func convert_date(int pos) {
switch(pos) {
case 0: return convert_syslog;
case 1: return convert_tai64;
case 2: return convert_clf;
case 3: return convert_nagios;
default: return (func)NULL;
}
}
精彩评论