commandButton/commandLink/ajax action/listener method not invoked or input value not set/updated
Sometimes, when using <h:commandLink>
, <h:commandButton>
or开发者_开发技巧 <f:ajax>
, the action
, actionListener
or listener
method associated with the tag are simply not being invoked. Or, the bean properties are not updated with submitted UIInput
values.
What are the possible causes and solutions for this?
Introduction
Whenever an UICommand
component (<h:commandXxx>
, <p:commandXxx>
, etc) fails to invoke the associated action method, or an UIInput
component (<h:inputXxx>
, <p:inputXxxx>
, etc) fails to process the submitted values and/or update the model values, and you aren't seeing any googlable exceptions and/or warnings in the server log, also not when you configure an ajax exception handler as per Exception handling in JSF ajax requests, nor when you set below context parameter in web.xml
,
<context-param>
<param-name>javax.faces.PROJECT_STAGE</param-name>
<param-value>Development</param-value>
</context-param>
and you are also not seeing any googlable errors and/or warnings in browser's JavaScript console (press F12 in Chrome/Firefox23+/IE9+ to open the web developer toolset and then open the Console tab), then work through below list of possible causes.
Possible causes
UICommand
andUIInput
components must be placed inside anUIForm
component, e.g.<h:form>
(and thus not plain HTML<form>
), otherwise nothing can be sent to the server.UICommand
components must also not havetype="button"
attribute, otherwise it will be a dead button which is only useful for JavaScriptonclick
. See also How to send form input values and invoke a method in JSF bean and <h:commandButton> does not initiate a postback.You cannot nest multiple
UIForm
components in each other. This is illegal in HTML. The browser behavior is unspecified. Watch out with include files! You can useUIForm
components in parallel, but they won't process each other during submit. You should also watch out with "God Form" antipattern; make sure that you don't unintentionally process/validate all other (invisible) inputs in the very same form (e.g. having a hidden dialog with required inputs in the very same form). See also How to use <h:form> in JSF page? Single form? Multiple forms? Nested forms?.No
UIInput
value validation/conversion error should have occurred. You can use<h:messages>
to show any messages which are not shown by any input-specific<h:message>
components. Don't forget to include theid
of<h:messages>
in the<f:ajax render>
, if any, so that it will be updated as well on ajax requests. See also h:messages does not display messages when p:commandButton is pressed.If
UICommand
orUIInput
components are placed inside an iterating component like<h:dataTable>
,<ui:repeat>
, etc, then you need to ensure that exactly the samevalue
of the iterating component is been preserved during the apply request values phase of the form submit request. JSF will reiterate over it to find the clicked link/button and submitted input values. Putting the bean in the view scope and/or making sure that you load the data model in@PostConstruct
of the bean (and thus not in a getter method!) should fix it. See also How and when should I load the model from database for h:dataTable.If
UICommand
orUIInput
components are included by a dynamic source such as<ui:include src="#{bean.include}">
, then you need to ensure that exactly the same#{bean.include}
value is preserved during the view build time of the form submit request. JSF will reexecute it during building the component tree. Putting the bean in the view scope and/or making sure that you load the data model in@PostConstruct
of the bean (and thus not in a getter method!) should fix it. See also How to ajax-refresh dynamic include content by navigation menu? (JSF SPA).The
rendered
attribute of the component and all of its parents and thetest
attribute of any parent<c:if>
/<c:when>
should not evaluate tofalse
during the apply request values phase of the form submit request. JSF will recheck it as part of safeguard against tampered/hacked requests. Storing the variables responsible for the condition in a@ViewScoped
bean or making sure that you're properly preinitializing the condition in@PostConstruct
of a@RequestScoped
bean should fix it. The same applies to thedisabled
andreadonly
attributes of the component, which should not evaluate totrue
during apply request values phase. See also JSF CommandButton action not invoked, Form submit in conditionally rendered component is not processed, h:commandButton is not working once I wrap it in a <h:panelGroup rendered> and Force JSF to process, validate and update readonly/disabled input components anywayThe
onclick
attribute of theUICommand
component and theonsubmit
attribute of theUIForm
component should not returnfalse
or cause a JavaScript error. There should in case of<h:commandLink>
or<f:ajax>
also be no JS errors visible in the browser's JS console. Usually googling the exact error message will already give you the answer. See also Manually adding / loading jQuery with PrimeFaces results in Uncaught TypeErrors.If you're using Ajax via JSF 2.x
<f:ajax>
or e.g. PrimeFaces<p:commandXxx>
, make sure that you have a<h:head>
in the master template instead of the<head>
. Otherwise JSF won't be able to auto-include the necessary JavaScript files which contains the Ajax functions. This would result in a JavaScript error like "mojarra is not defined" or "PrimeFaces is not defined" in browser's JS console. See also h:commandLink actionlistener is not invoked when used with f:ajax and ui:repeat.If you're using Ajax, and the submitted values end up being
null
, then make sure that theUIInput
andUICommand
components of interest are covered by the<f:ajax execute>
or e.g.<p:commandXxx process>
, otherwise they won't be executed/processed. See also Submitted form values not updated in model when adding <f:ajax> to <h:commandButton> and Understanding PrimeFaces process/update and JSF f:ajax execute/render attributes.If the submitted values still end up being
null
, and you're using CDI to manage beans, then make sure that you import the scope annotation from the correct package, else CDI will default to@Dependent
which effectively recreates the bean on every single evaluation of the EL expression. See also @SessionScoped bean looses scope and gets recreated all the time, fields become null and What is the default Managed Bean Scope in a JSF 2 application?If a parent of the
<h:form>
with theUICommand
button is beforehand been rendered/updated by an ajax request coming from another form in the same page, then the first action will always fail in JSF 2.2 or older. The second and subsequent actions will work. This is caused by a bug in view state handling which is reported as JSF spec issue 790 and currently fixed in JSF 2.3. For older JSF versions, you need to explicitly specify the ID of the<h:form>
in therender
of the<f:ajax>
. See also h:commandButton/h:commandLink does not work on first click, works only on second click.If the
<h:form>
hasenctype="multipart/form-data"
set in order to support file uploading, then you need to make sure that you're using at least JSF 2.2, or that the servlet filter who is responsible for parsing multipart/form-data requests is properly configured, otherwise theFacesServlet
will end up getting no request parameters at all and thus not be able to apply the request values. How to configure such a filter depends on the file upload component being used. For Tomahawk<t:inputFileUpload>
, check this answer and for PrimeFaces<p:fileUpload>
, check this answer. Or, if you're actually not uploading a file at all, then remove the attribute altogether.Make sure that the
ActionEvent
argument ofactionListener
is anjavax.faces.event.ActionEvent
and thus notjava.awt.event.ActionEvent
, which is what most IDEs suggest as 1st autocomplete option. Having no argument is wrong as well if you useactionListener="#{bean.method}"
. If you don't want an argument in your method, useactionListener="#{bean.method()}"
. Or perhaps you actually want to useaction
instead ofactionListener
. See also Differences between action and actionListener.Make sure that no
PhaseListener
or anyEventListener
in the request-response chain has changed the JSF lifecycle to skip the invoke action phase by for example callingFacesContext#renderResponse()
orFacesContext#responseComplete()
.Make sure that no
Filter
orServlet
in the same request-response chain has blocked the request fo theFacesServlet
somehow. For example, login/security filters such as Spring Security. Particularly in ajax requests that would by default end up with no UI feedback at all. See also Spring Security 4 and PrimeFaces 5 AJAX request handling.If you are using a PrimeFaces
<p:dialog>
or a<p:overlayPanel>
, then make sure that they have their own<h:form>
. Because, these components are by default by JavaScript relocated to end of HTML<body>
. So, if they were originally sitting inside a<form>
, then they would now not anymore sit in a<form>
. See also p:commandbutton action doesn't work inside p:dialogBug in the framework. For example, RichFaces has a "conversion error" when using a
rich:calendar
UI element with adefaultLabel
attribute (or, in some cases, arich:placeholder
sub-element). This bug prevents the bean method from being invoked when no value is set for the calendar date. Tracing framework bugs can be accomplished by starting with a simple working example and building the page back up until the bug is discovered.
Debugging hints
In case you still stucks, it's time to debug. In the client side, press F12 in webbrowser to open the web developer toolset. Click the Console tab so see the JavaScript conosle. It should be free of any JavaScript errors. Below screenshot is an example from Chrome which demonstrates the case of submitting an <f:ajax>
enabled button while not having <h:head>
declared (as described in point 7 above).
Click the Network tab to see the HTTP traffic monitor. Submit the form and investigate if the request headers and form data and the response body are as per expectations. Below screenshot is an example from Chrome which demonstrates a successful ajax submit of a simple form with a single <h:inputText>
and a single <h:commandButton>
with <f:ajax execute="@form" render="@form">
.
(warning: when you post screenshots from HTTP request headers like above from a production environment, then make sure you scramble/obfuscate any session cookies in the screenshot to avoid session hijacking attacks!)
In the server side, make sure that server is started in debug mode. Put a debug breakpoint in a method of the JSF component of interest which you expect to be called during processing the form submit. E.g. in case of UICommand
component, that would be UICommand#queueEvent()
and in case of UIInput
component, that would be UIInput#validate()
. Just step through the code execution and inspect if the flow and variables are as per expectations. Below screenshot is an example from Eclipse's debugger.
If your h:commandLink
is inside a h:dataTable
there is another reason why the h:commandLink
might not work:
The underlying data-source which is bound to the h:dataTable
must also be available in the second JSF-Lifecycle that is triggered when the link is clicked.
So if the underlying data-source is request scoped, the h:commandLink
does not work!
While my answer isn't 100% applicable, but most search engines find this as the first hit, I decided to post it nontheless:
If you're using PrimeFaces (or some similar API) p:commandButton
or p:commandLink
, chances are that you have forgotten to explicitly add process="@this"
to your command components.
As the PrimeFaces User's Guide states in section 3.18, the defaults for process
and update
are both @form
, which pretty much opposes the defaults you might expect from plain JSF f:ajax
or RichFaces, which are execute="@this"
and render="@none"
respectively.
Just took me a looong time to find out. (... and I think it's rather unclever to use defaults that are different from JSF!)
I would mention one more thing that concerns Primefaces's p:commandButton
!
When you use a p:commandButton
for the action that needs to be done on the server, you can not use type="button"
because that is for Push buttons which are used to execute custom javascript without causing an ajax/non-ajax request to the server.
For this purpose, you can dispense the type
attribute (default value is "submit"
) or you can explicitly use type="submit"
.
Hope this will help someone!
Got stuck with this issue myself and found one more cause for this problem. If you don't have setter methods in your backing bean for the properties used in your *.xhtml , then the action is simply not invoked.
I recently ran into a problem with a UICommand not invoking in a JSF 1.2 application using IBM Extended Faces Components.
I had a command button on a row of a datatable (the extended version, so <hx:datatable>
) and the UICommand would not fire from certain rows from the table (the rows that would not fire were the rows greater than the default row display size).
I had a drop-down component for selecting number of rows to display. The value backing this field was in RequestScope
. The data backing the table itself was in a sort of ViewScope
(in reality, temporarily in SessionScope
).
If the row display was increased via the control which value was also bound to the datatable's rows
attribute, none of the rows displayed as a result of this change could fire the UICommand when clicked.
Placing this attribute in the same scope as the table data itself fixed the problem.
I think this is alluded to in BalusC #4 above, but not only did the table value need to be View or Session scoped but also the attribute controlling the number of rows to display on that table.
I had this problem as well and only really started to hone in on the root cause after opening up the browser's web console. Until that, I was unable to get any error messages (even with <p:messages>
). The web console showed an HTTP 405 status code coming back from the <h:commandButton type="submit" action="#{myBean.submit}">
.
In my case, I have a mix of vanilla HttpServlet's providing OAuth authentication via Auth0 and JSF facelets and beans carrying out my application views and business logic.
Once I refactored my web.xml, and removed a middle-man-servlet, it then "magically" worked.
Bottom line, the problem was that the middle-man-servlet was using RequestDispatcher.forward(...) to redirect from the HttpServlet environment to the JSF environment whereas the servlet being called prior to it was redirecting with HttpServletResponse.sendRedirect(...).
Basically, using sendRedirect() allowed the JSF "container" to take control whereas RequestDispatcher.forward() was obviously not.
What I don't know is why the facelet was able to access the bean properties but could not set them, and this clearly screams for doing away with the mix of servlets and JSF, but I hope this helps someone avoid many hours of head-to-table-banging.
I had lots of fun debugging an issue where a <h:commandLink>
's action in richfaces
datatable
refused to fire. The table used to work at some point but stopped for no apparent reason. I left no stone unturned, only to find out that my rich:datatable
was using the wrong rowKeyConverter
which returned nulls that richfaces happily used as row keys. This prevented my <h:commandLink>
action from getting called.
One more possibility: if the symptom is that the first invocation works, but subsequent ones do not, you may be using PrimeFaces 3.x with JSF 2.2, as detailed here: No ViewState is sent.
I fixed my problem with placing the:
<h:commandButton class="btn btn-danger" value = "Remove" action="#{deleteEmployeeBean.delete}"></h:commandButton>
In:
<h:form>
<h:commandButton class="btn btn-danger" value = "Remove" action="#{deleteEmployeeBean.delete}"></h:commandButton>
</h:form>
This is the solution, which is worked for me.
<p:commandButton id="b1" value="Save" process="userGroupSetupForm"
actionListener="#{userGroupSetupController.saveData()}"
update="growl userGroupList userGroupSetupForm" />
Here, process="userGroupSetupForm" atrribute is mandatory for Ajax call. actionListener is calling a method from @ViewScope Bean. Also updating growl message, Datatable: userGroupList and Form: userGroupSetupForm.
<ui:composition>
<h:form id="form1">
<p:dialog id="dialog1">
<p:commandButton value="Save" action="#{bean.method1}" /> <!--Working-->
</p:dialog>
</h:form>
<h:form id="form2">
<p:dialog id="dialog2">
<p:commandButton value="Save" action="#{bean.method2}" /> <!--Not Working-->
</p:dialog>
</h:form>
</ui:composition>
To solve;
<ui:composition>
<h:form id="form1">
<p:dialog id="dialog1">
<p:commandButton value="Save" action="#{bean.method1}" /> <!-- Working -->
</p:dialog>
<p:dialog id="dialog2">
<p:commandButton value="Save" action="#{bean.method2}" /> <!--Working -->
</p:dialog>
</h:form>
<h:form id="form2">
<!-- .......... -->
</h:form>
</ui:composition>
精彩评论