How can this query be improved?

I am using LINQ to write a query - one query shows all active customers , and another shows all active as well as inactive customers.

 if(showall)
 {
   var prod = Dataclass.Customers.Where(multiple factors ) (all inactive + active)
 }
 else
 {
   var prod = Dataclass.Customers.Where(multiple factors & active=true) (only active)
 }

Can I do this u开发者_开发百科sing only one query? The issue is that, multiple factors are repeated in both the queries

thanks

var customers = Dataclass.Customers.Where(multiple factors);
var activeCust = customers.Where(x => x.active);

I really don't understand the question either. I wouldn't want to make this a one-liner because it would make the code unreadable

I'm assuming you are trying to minimze the number of roundtrips?

If "multiple factors" is the same, you can just filter for active users after your first query:

var onlyActive = prod.Where(p => p.active == true);

Wouldn't you just use your first query to return all customers?? If not you'd be returning the active users twice.

Options I'd consider

• Bring all customers once, order by 'status' column so you can easily split them into two sets
• Focus on minimizing DB roundtrips. Whatever you do in the front end costs an order of magnitude less than going to the DB.
• Revise user requirements. For ex. consider paging on results - it's unlikely that end user will need all customers at once.