Should QGraphicsItem::boundingRect() include child bounding rects?

Googling suggests that it should.

But the dragdroprobot example implementation (on th开发者_高级运维e parent Robot object) suggests not:

QRectF Robot::boundingRect() const
{
    return QRectF();
}

Which is correct, or is there something more subtle going on?

Child items are painted directly by the scene not by the parent, and according to the documentation about boundingRect():

QGraphicsView uses this to determine whether the item requires redrawing.

So, if there is no drawing to do in the parent, there is no need to return a non-null bounding rectangle, even if the parent has child items. And if there is some drawing in the parent, it only needs to contain its own bounding rectangle.

Under normal usage the children of your QGraphicsItem are contained within its bounding rect, but depending on your implementation I don't believe that this is required.

If you need the bounding rect of an item's children you can simply use

QGraphicsItem::childrenBoundingRect();

Possibly related:

1. QGraphicItemGroup is different.

The documentation says:

The boundingRect() function of QGraphicsItemGroup returns the bounding rectangle of all items in the item group.

(However, the documentation does not say that boundingRect is reimplemented, although QGraphicsItemGroup inherits QGraphicsItem. Thats probably a flaw in the documentation.)

2. QGraphicItem.shape() seems to be similar to boundingRect() in that the view calls it for each instance (for purposes of picking i.e. QGraphicsView.items(), similarly as boundingRect() is called for purposes of determining what needs to be redrawn).

As far as I can tell, QGraphicItemGroup.shape() is never called by QGraphicsView.items(). The documentation does not say that it is reimplemented.