开发者

Problem with ListView. When i changue the color of an item (pressing on it) and i scrolldown, another item appears with color changed

I'm having a very strange problem with my custom listview.

This Listview shows a lot of names and some more data, and each item haves an onClick listener, and when i press in one item, that item get's the background color changued to RED. ( arg1.setBackgroundColor(Color.RED); )

But something isn't working properly, because if i scrolldown the listview, another item appears colored on near of the bottom part of the list.

this is my code:

public class StartingSquad extends Activity {

public static List<Player> Players = new ArrayList<Player>();
public int selectedPosition=-1;
ListView l1;
private TextView TeamPowerValue=null;

public void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);

    MyApplication.updateStartingSquadOnPlayers(MyApplication.getPlayerTeam(),this);//actualizo los titulares

    Players=MyApplication.getPlayerTeam().getPlayers();

    setContentView(R.layout.startingsquad);
    TeamPowerValue = (TextView) findViewById(R.id.TeamPowerValue);
    l1 = (ListView) findViewById(R.id.ListView01);
    l1.setAdapter(new EfficientAdapter(this));

    TeamPowerValue.setText(""+MyApplication.getPlayerTeam().getPower());


    l1.setOnItemClickListener(new OnItemClickListener() {
        public void onItemClick(AdapterView<?> arg0, View arg1, int arg2, long arg3) {
            //Toast.makeText(getBaseContext(), "You clciked "+Players.get(arg2).getName(), Toast.LENGTH_SHORT).show();
            if (selectedPosition==-1) //si no hay ningun item seleccionado ya
            {
                arg1.setSelected(true);
                //arg1.setBackgroundResource(R.drawable.bg3);
                arg1.setBackgroundColor(Color.RED);

                selectedPosition=arg2;
            }
            else //si ya habiamos seleccionado un jugador
            {
                MyApplication.getPlayerTeam().changePlayerPositions(selectedPosition, arg2);
                selectedPosition=-1;
                MyApplication.updateStartingSquadOnPlayers(MyApplication.getPlayerTeam(),StartingSquad.this);//actualizo los titulares
                MyApplication.getPlayerTeam().calculatePower();
                TeamPowerValue.setText(""+MyApplication.getPlayerTeam().getPower());
                l1.setAdapter(new EfficientAdapter(StartingSquad.this));
            }
  开发者_开发知识库      }
    });
}

private static class EfficientAdapter extends BaseAdapter {

    private LayoutInflater mInflater;

    public EfficientAdapter(Context context) {
        mInflater = LayoutInflater.from(context);
    }

    public int getCount() {
        return Players.size();
    }

    public Object getItem(int position) {
        return position;
    }

    public long getItemId(int position) {
        return position;
    }


    public View getView(int position, View convertView, ViewGroup parent) {
        ViewHolder holder;
        if (convertView == null) {
            convertView = mInflater.inflate(R.layout.startingsquadlistview, null);
            holder = new ViewHolder();
            holder.text = (TextView) convertView.findViewById(R.id.PlayerPosition);
            holder.text2 = (TextView) convertView.findViewById(R.id.PlayerName);
            holder.text3 = (TextView) convertView.findViewById(R.id.PlayerPower);
            holder.text4 = (TextView) convertView.findViewById(R.id.PlayerStartingSquad);

            convertView.setTag(holder);
        } else {
            holder = (ViewHolder) convertView.getTag();
        }

        holder.text.setText(Players.get(position).getPosition());
        holder.text2.setText(Players.get(position).getName());
        holder.text2.setTextColor(Players.get(position).NameColor);
        holder.text3.setText(""+Players.get(position).getPower());
        holder.text4.setText("XX");

        return convertView;
    }

    static class ViewHolder {
        TextView text;
        TextView text2;
        TextView text3;
        TextView text4;
    }
}

}


Do background change not in onItemSelected but in adater getView().

if(position == selectedPosition) {
    convertView.setBackgroundColor(context.getResources().getColor(R.color.red));
} else {
    convertView.setBackgroundColor(context.getResources().getColor(R.color.default));
}


Try to remove this line:

l1.setAdapter(new EfficientAdapter(StartingSquad.this));

If you can't, tell me why?


One more thing: Edit this function:

    public View getView(int position, View convertView, ViewGroup parent) {
        ViewHolder holder;
        View convertViews;
        if (convertView == null) {
            convertViews = mInflater.inflate(R.layout.startingsquadlistview, null);
            holder = new ViewHolder();
            holder.text = (TextView) convertView.findViewById(R.id.PlayerPosition);
            holder.text2 = (TextView) convertView.findViewById(R.id.PlayerName);
            holder.text3 = (TextView) convertView.findViewById(R.id.PlayerPower);
            holder.text4 = (TextView) convertView.findViewById(R.id.PlayerStartingSquad);

            convertViews.setTag(holder);
        } else {
            convertViews = convertView;
            holder = (ViewHolder) convertViews.getTag();
        }

        holder.text.setText(Players.get(position).getPosition());
        holder.text2.setText(Players.get(position).getName());
        holder.text2.setTextColor(Players.get(position).NameColor);
        holder.text3.setText(""+Players.get(position).getPower());
        holder.text4.setText("XX");

        return convertViews;
    }
0

上一篇:

下一篇:

精彩评论

暂无评论...
验证码 换一张
取 消

最新问答

问答排行榜