SQL Query using INNER JOIN won't sort properly.

I've created the following SQL query to export order data from the database.

SELECT orders.orders_id as uuid,
        orders.customers_id as order__customer_id,
        orders.customers_name as order__customer_name,
        orders.customers_company as order__customer_company,
        orders.customers_street_address as order__customer_street_address,
        orders.customers_suburb as order__customer_suburb,
        orders.customer开发者_高级运维s_city as order__customer_city,
        orders.customers_postcode as order__customer_postcode,
        orders.customers_state as order__customer_state,
        orders.customers_country as order__customer_country,
        orders.customers_telephone as order__customer_telephone,
        orders.customers_email_address as order__customer_email_address,
        orders.delivery_name as order__delivery_name,
        orders.delivery_company as order__delivery_company,
        orders.delivery_street_address as order__delivery_street_address,
        orders.delivery_suburb as order__delivery_suburb,
        orders.delivery_city as order__delivery_city,
        orders.delivery_postcode as order__delivery_postcode,
        orders.delivery_state as order__delivery_state,
        orders.delivery_country as order__delivery_country,
        orders.billing_name as order__billing_name,
        orders.billing_company as order__billing_company,
        orders.billing_street_address as order__billing_street_address,
        orders.billing_suburb as order__billing_suburb,
        orders.billing_city as order__billing_city,
        orders.billing_postcode as order__billing_postcode,
        orders.billing_state as order__billing_state,
        orders.billing_country as order__billing_country,
        orders.payment_method as order__payment_method,
        orders.last_modified as order__last_modified,
        orders.date_purchased as order__date_purchased,
        orders.orders_status as order__order_status,
        orders_status.orders_status_name as order__order_status_name,
        orders.orders_date_finished as order__date_finished,
        orders.currency as order__currency,
        orders.currency_value as order__currency_value,
        ot1.orders_id,
        value AS ot_subtotal,
        ot2.ot_shipping,
        ot3.ot_total
        FROM orders, orders_status, orders_total as ot1 
        INNER JOIN ( SELECT orders_id, value AS ot_shipping FROM orders_total WHERE class='ot_shipping' ) AS ot2 ON ot1.orders_id=ot2.orders_id AND ot1.class='ot_subtotal' 
        INNER JOIN ( SELECT orders_id, value AS ot_total FROM orders_total WHERE class='ot_total' ) AS ot3 ON ot1.orders_id=ot3.orders_id AND ot1.class='ot_subtotal'
        WHERE ot1.orders_id = ot2.orders_id and orders.orders_status = orders_status.orders_status_id;

It works fantastic, except it's creating 4 rows for every record. Currently there are 4 orders, so there are 16 rows (17 including the column names), when there should only be 4 (5 including the column names).

Thanks!

When it should only be 4 rows (5 including the column names) as there are only 4 orders.

Much appreciated!

You seem to be missing any JOIN that would link orders to orders_total. This would be clearer if you rewrote with explicit JOIN syntax instead of mixing the new and old styles.

FROM   orders
       INNER JOIN orders_status ON orders.orders_status = orders_status.orders_status_id
       INNER JOIN orders_total as ot1 /*<--Missing Condition here
                                          ON orders.orders_id = ot1.orders_id */
       INNER JOIN (SELECT orders_id,
                          value AS ot_shipping
                   FROM   orders_total
                   WHERE  class = 'ot_shipping') AS ot2
         ON ot1.orders_id = ot2.orders_id
       INNER JOIN (SELECT orders_id,
                          value AS ot_total
                   FROM   orders_total
                   WHERE  class = 'ot_total') AS ot3
         ON ot1.orders_id = ot3.orders_id

In any event you don't need to Join onto the same table 3 times for this. You can use something like the below.

SELECT orders.orders_id,
       MAX(CASE
             WHEN orders_total.class = 'ot_subtotal' THEN value
           END) AS ot_subtotal,
       MAX(CASE
             WHEN orders_total.class = 'ot_shipping' THEN value
           END) AS ot_shipping,
       MAX(CASE
             WHEN orders_total.class = 'ot_total' THEN value
           END) AS ot_total
FROM   orders
       INNER JOIN orders_status
         ON orders.orders_status = orders_status.orders_status_id
       INNER JOIN orders_total
         ON orders_total.orders_id = orders.orders_id
WHERE  orders_total.class in ( 'ot_subtotal', 'ot_shipping', 'ot_total' )
GROUP  BY orders.orders_id  

Try using SELECT DISTINCT in your query.

SELECT DISTINCT orders.orders_id as uuid...
FROM orders, orders_status, orders_total as ot1 
INNER JOIN ( SELECT orders_id, value AS ot_shipping FROM orders_total WHERE class='ot_shipping' ) AS ot2 ON ot1.orders_id=ot2.orders_id AND ot1.class='ot_subtotal' 
INNER JOIN ( SELECT orders_id, value AS ot_total FROM orders_total WHERE class='ot_total' ) AS ot3 ON ot1.orders_id=ot3.orders_id AND ot1.class='ot_subtotal'
WHERE ot1.orders_id = ot2.orders_id and orders.orders_status = orders_status.orders_status_id;

EDIT:

I updated your FROM portion to the below using INNER JOINs on all of the tables instead of ','. I don't know your table structures so I am guessing on your join fields.

FROM orders
INNER JOIN orders_status
    ON orders.orders_status = orders_status.orders_status_id
INNER JOIN orders_total as ot1 
    ON orders.orders_id = ot1.orders_id
INNER JOIN ( SELECT orders_id, value AS ot_shipping FROM orders_total WHERE class='ot_shipping' ) AS ot2 
    ON ot1.orders_id=ot2.orders_id 
INNER JOIN ( SELECT orders_id, value AS ot_total FROM orders_total WHERE class='ot_total' ) AS ot3 
    ON ot1.orders_id=ot3.orders_id
WHERE ot1.class='ot_subtotal'