v.getTag() returns null instead of ViewHolder
I have a customized adapter that has a header and customized rows. Sometimes my v.getTag() returns null where I have stored my ViewHolder. It does not happen all the times and I can not figure out when and why it accurs.
@Override
public View getView(int position, View convertView, ViewGroup parent) {
View v = convertView;
//Header
if(items.hasDescription() && 0 == position) {
LayoutInflater vi = (LayoutInflater) context.getSystemService(Context.LAYOUT_INFLATER_SERVICE);
v = vi.inflate(R.layout.app_list_header, null);
((TextView) v.findViewById(R.id.app_list_header_description_text)).setText(items.getDescription());
return v;
}
ViewHolder holder;
// Inflate app view.
if (v == null || v.getTag() == null) {
LayoutInflater vi = (LayoutInflater) context.getSystemService(Context.LAYOUT_INFLATER_SERVICE);
v = vi.inflate(textViewResourceId, null); //TODO: parent instead of null?
holder = new ViewHolder();
holder.title = (TextView) v.findViewById(R.id.title);
holder.company = (TextView) v.findViewById(R.id.company);
holder.priceOrStatus = (TextView) v.findViewById(R.id.price);
holder.rating = (RatingBar) v.findViewById(R.id.rating);
holder.icon = (ImageView) v.findViewById(R.id.icon);
v.setTag(holder);
} else {
holder = (ViewHolder) v.getTag();
}
}
App app;
if(items.hasDescription()) {
app = items.get(position-1);
} else {
app = items.get(position);
}
// TODO: Do we need this?
if (null == app || 开发者_JS百科null == holder) {
Log.d(TAG, "app: " +app +" holder: " +holder);
return v;
}
//TODO: FIX THE XML BEFORE SO WE DO NOT NEED TO TRIM IT.
// And get rid of all these ifs!!
if(holder.title != null) {
holder.title.setText(app.getTitle().trim());
}
Can anyone help me out?
You're using the standard pattern for a custom ListAdapter
here. Not all views will be recycled e.g. when they are first created to fill the ListView
.
You may also want to take a reference the the LayoutInflater
when you create the adapter to slightly improve efficiency, see snippet below
private class AlertListAdapter extends ArrayAdapter< Alert >
{
private ViewHolder holder;
private LayoutInflater mInflater;
public AlertListAdapter( Context context, List< Alert > items )
{
super( context, R.layout.dashboard_layout, items );
mInflater = LayoutInflater.from( context );
}
public View getView( int position, View recycledView, ViewGroup parent )
{
if ( recycledView == null || recycledView.getTag() == null )
{
recycledView = mInflater.inflate( R.layout.list_item, null );
holder = new ViewHolder();
holder.header = ( LinearLayout ) recycledView.findViewById( R.id.alert_list_item_header );
holder.header_text = ( TextView ) recycledView.findViewById( R.id.alert_list_item_header_text );
holder.header_count = ( TextView ) recycledView.findViewById( R.id.alert_list_item_header_count );
holder.name = ( TextView ) recycledView.findViewById( R.id.alert_list_item_name );
holder.distance = ( TextView ) recycledView.findViewById( R.id.alert_list_item_distance );
recycledView.setTag( holder );
}
else
{
holder = ( ViewHolder ) recycledView.getTag();
}
holder.header_text.setText( title.substring( 0, space ) );
holder.name.setText( title.substring( space + 1 ) );
holder.header_count.setText( count );
holder.header.setBackgroundResource( resourceID );
return recycledView;
}
}
Essentially you must always be prepared for v.getTag()
to return null and inflate a new View
accordingly.
精彩评论