Integration Tests started to fail with grails upgrade

I upgraded a grails app from 1.2.2 to 1.3.7 after this upgrade a few integration tests have started to throw the following error the 'validateAndSaveList' is a method on a service used by the service I'm testing. These tests were passing before the upgrade and they will also pass if I run just the integration test phase with grails test-app -integration

junit.framework.AssertionFailedError: No more calls to 'validateAndSaveList' expected at this point. End of demands.

Code:

import com.e.domain.*
import com.e.exception.GORMServiceException
import com.e.controller.SecurityUserCommand



class AccountServiceTests extends GroovyTestCase
{
def accountService

void testRegisterWithMinimumInfo()
{
    def clinic = new Clinic(name:'clinicName')
    def securityUserCommand = new SecurityUserCommand(username:'username', password:"password", confirm:"password")
    def clinicUser = new ClinicUser(firstName:'fname', lastName:'lname', emailAddress:'abc@abc.com')
    clinicUser.clinic = clinic
    //clinicUser.securityUser = securityUser
    clinic.address = new Address()
    //  TODO - JsecUser no longer in use        
    def role = new ShiroRole(name:'TEST')
    //def subscription = ESubscription.findByName('Charter Member')
    def subscription = new ESubscription(
        name:'Charter Member',
        description:'Charter Member',
        periodType:'Monthly',
        numPeriods:12,
        amountPerPeriod:25.00,
        electronicSubmissionRate:0.00,
        accountingRate:0.01,
        numAllowedUsers:4,
        startDate: today -1,
        endDate: today+1
    )
    subscription.save(flush:true)
    if(subscription.hasErrors())
    println subscription.errors
    assertNotNull subscription
    clinicUser.empathicCustomerProfile.subscription = subscription
    def result = accountService.register(clinic, securityUserCommand, clinicUser, role)
    assert result.success
    assert result.clinic.id
    assert result.securityUser?.id
    assert result.clinicUser.id
}

StackTrace

junit.framework.AssertionFailedError: No more calls to 'validateAndSaveList' expected at this point. End of demands.
 at grails.test.MockClosureProxy.doBeforeCall(MockClosureProxy.java:66)
 at grails.test.AbstractClosureProxy.call(AbstractClosu开发者_开发百科reProxy.java:74)
 at grails.test.GrailsMock$_createMock_closure1.doCall(GrailsMock.groovy:125)
 at com.e.service.AccountService.register(AccountService.groovy:46)
 at com.e.service.AccountService$register.call(Unknown Source)
 at AccountServiceTests.testRegisterWithMinimumInfo(AccountServiceTests.groovy:53)

this answer comes from working the issue out in the comments:

the exception you are getting clearly indicates that somewhere you have put a mock object in your service, and the service is calling the mock object in a way it was not set up to handle.

The root problem as seen from @hvgotcodes is that there was a mock object for the service even though in that given test there was no mocking happening.

This happened in grails 1.3.7

I found a unit test that was doing the following:

    def dataBindServiceControl = mockFor(DataBindService)
    dataBindServiceControl.demand.safeBind{}
    dataBindServiceControl.demand.extractPhones{}
    dataBindServiceControl.demand.validateAndSaveList{l-> return true}
    def dataBindService = dataBindServiceControl.createMock()
    controller.dataBindService = dataBindService

If those tests were removed then all the integration tests would pass so to solve with out rewriting the tests I added the following to the tear down method.

    GroovySystem.metaClassRegistry.removeMetaClass(DataBindService)

With this addition the tests are now working correctly in grails 1.3.7