Catch two exceptions in the same catch block?

I have a method that can throw two开发者_如何转开发 different exceptions, CommuncationException and SystemException. In both cases I do the same three-line code block.

try {
 ...
}

catch (CommunicationException ce) {
   ...
}

catch {SystemExcetion se) {
   ... 
}

Is there any possibility to do it like that?

try {
   ...
}

catch (CommunicationException ce, SystemException se) {
   ...
}

Then I would not have to write this much code. I know I could extract the exception handling to a private method, but since the code is only 3 lines long, the method definition would take more code than the body itself.

If you can upgrade your application to C# 6 you are lucky. The new C# version has implemented Exception filters. So you can write this:

catch (Exception ex) when (ex is CommunicationException || ex is SystemException) {
    //handle it
}

Some people think this code is the same as

catch (Exception ex) {                
    if (ex is CommunicationException || ex is SystemException) {
        //handle it
    }
    throw;
}

But it´s not. Actually this is the only new feature in C# 6 that is not possible to emulate in prior versions. First, a re-throw means more overhead than skipping the catch. Second, it is not semantically equivalent. The new feature preserves the stack intact when you are debugging your code. Without this feature the crash dump is less useful or even useless.

See a discussion about this on CodePlex. And an example showing the difference.

In fact, you could catch only SystemException and it would handle CommunicationException too, because CommunicationException is derived from SystemException

catch (SystemException se) {
   ... //this handles both exceptions
}

Unfortunately, there is no way. The syntax you used is invalid and a fall through like in a switch-statement isn't possible either. I think you need to go with the private method.

A little hacky work-around would be something like this:

var exceptionHandler = new Action<Exception>(e => { /* your three lines */ });
try
{
    // code that throws
}
catch(CommuncationException ex)
{
    exceptionHandler(ex);
}
catch(SystemException ex)
{
    exceptionHandler(ex);
}

You need to decide for yourself if this makes any sense.

No, you can't do it that way. The only way i know of is to catch a generic Exception and then check what type it is:

try
{
   ...
}
catch(Exception ex)
{
   if(ex is CommunicationException || ex is SystemException)
   {
      ...
   }
   else
   {
     ... // throw; if you don't want to handle it
   }
}

What about

try {


...
}

catch (CommunicationException ce) {
   HandleMyError(ce);
}

catch {SystemExcetion se) {
   HandleMyError(se);
}

private void HandleMyError(Exception ex)
{
// handle your error
}

Possible Duplicate of

Catch multiple exceptions at once?

I quote the answer here:

 catch (Exception ex)            
       {                
           if (ex is FormatException ||
               ex is OverflowException)
           {
               WebId = Guid.Empty;
               return;
           }
           else
           {
               throw;
           }
       }

Dragging this one up from the depths of history as it happened to pop up in some search results.

With the advent of C# 7.0 (which arrived in 2017 with VS2017, .net framework 4.7 and dotnet core 2.0) you can now do things like this:

try {
   ...
}
catch (Exception e) when (e is CommunicationException || e is SystemException) {
   ...
}

Since you're doing the same for both type of exceptions, you could just go:

try
{
    //do stuff
}
catch(Exception ex)
{
    //normal exception handling here
}

Only catch explicit Exception types if you need to do something unique for it.