WPF CheckBox Binding - Altering value in Property Set does not affect UI

i have a simple checkbox

<CheckBox IsChecked="{Binding ForceInheritance}"/>

In Code i have a class with "INotifyPropertyChanged" and the Property

public bool ForceInheritance
{
  get { return forceInheritance; }

  set
  {
    if (forceInheritance != value)
    {
      value = SomeTest();

      开发者_开发百科if (forceInheritance != value)
      {
        //something is done here.
      }

      OnPropertyChanged("ForceInheritance");
    }
  }
}

If SomeTest() returns !value so the underlying data does not have to change the CheckBox still changes its IsChecked state.

For example:

ForceInheritance is false.

CheckBox is clicked.

SomeTest() returns false.

--> The underlying data is not changed

--> I would expect the CheckBox to stay unchecked

The CheckBox gets checked.

What can i do to not change the IsChecked state of the CheckBox when the setter does not actually change the value?

I thought the "OnPropertyChanged("ForceInheritance");" would do the trick but it didn't.

Thank you for your time.

This problems occurs because when you click checkbox it s value is changed. Then binding causes property set. There you manipulate with its value and hope that calling OnPropertyChanged will cause back binding action updating checkbox value. But doesn't work because updating control after updating property may produce infinite updating loop. To prevent this PropertyChanged is ignored.

What can you do is to move some logic of your property setter to binding validation rule. You can read here about validation rules or leave a comment if you need more information or examples.

Hope it helps.

I would expect the CheckBox to stay unchecked

Now, it seems that CheckBox working as you expect. Something must have changed recently because it works differently now.

Previously

When I needed to correct a value in the setter I use Dispatcher.

public bool IsActive
{
    get => _isActive;

    set
    {
        if (_isActive != value)
        {
            if (value)
            {
                if (!CanActive())
                {
                    Application.Current.Dispatcher.BeginInvoke((Action)(() => IsActive = false));
                    return;
                }
            } 
            
            _isActive = value;
            OnPropertyChanged(nameof(IsActive));
        }
    }
}

Now

Now, I don't have to change a value back to false. This works even if I remove OnPropertyChanged call, because after the setter is called, the getter is also called. It looks like the CheckBox is now correcting its state.

public bool IsActive
{
    get => _isActive;

    set
    {
        if (_isActive != value)
        {
            if (value)
            {
                if (!CanActive())
                {
                    return;
                }
            } 
            
            _isActive = value;
            OnPropertyChanged(nameof(IsActive));
        }
    }
}