Moving a rectangle in Swing JPanel: original stays

I'm trying to make a tower of hanoi solver which simply solves the hanoi without any mouse events. The problem is when I move the rectangle the original remains, even after I repaint. I've searched the net and tried changing the code around but nonthing worked. I am using a JFrame with a JPanel inside of it if that changes anything.

I have my disk class here which is just a rectangle with colour.

class Disk extends Rectangle {

    Color diskColour;

    public Disk(int a, int b, int c, int d, Color colour) {
        x = a;
        y = b;
        width = c;
        height = d;
        diskColour = colour;
    }

    public Color getColour() {
        return diskColour;
    }

    public void paintSquare(Graphics g) {
        repaint();
        g.setColor(diskColour);
        g.fillRect(x, y, width, height);
        repaint();


    }
}

Here is my code where I actually call the paintSquare method:

    public void simpleMoveDisk(Disk[] disks, int n, Graphics g) {

    disks[n].setLocation(30,25);
    disks[n].paintSquare开发者_JS百科(g);
    repaint();

}

The paintSquare method paints the disk, while the setLocation method changes its coordinates. When this runs the rectangle occurs in the new location, however the old one still remains. Any help is appreciated, thanks in advance.

You are calling repaint() in several places and you shouldn't be.

Have your the top level class that is doing the painting, call the paintSquare method and any other method that is needed. Those methods should not be calling repaint().

Also your simple move disk is really strange in the fact that it passes an array of Disks, an index, and a graphics object. Instead make it just take in a Disk. Just pass it the one out of the array that is needed to be updated. Then let whatever class that calls simpleMoveDisk, separately make a call to repaint instead of trying to paint and update the model in the same method.